fix(ActionSheet): fix that close is invalid without title #11213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
想请教下，如果同一个issue，同时修复2.x和3.x（4.x），是像现在这样提交两次pr么... |
是的哈，4.x 的小改动如果需要同步到 3.x，大多数情况我可以直接 cherry-pick 过去。 但如果想从 4.x 同步到 2.x，就得单独再提一个 PR 了。 |
chenjiahan
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #11211
ActionSheet在苹果手机上只有close图标时（title设置一个空格），无法关闭。该问题在2.x及3.x都存在（2.x稍后修复）。