Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Picker): add selectedIndexes to the confirm event #11329

Merged
merged 1 commit into from Nov 30, 2022
Merged

feat(Picker): add selectedIndexes to the confirm event #11329

merged 1 commit into from Nov 30, 2022

Conversation

wjw-gavin
Copy link
Collaborator

#11326

几个不确定点：

  1. 这个属性是否确定要加？
  2. 凡是用到picker的都会受影响吧（需要大佬check下）？
  3. 该参数是增加到getEventParams还是单独给confirm加（目前是只给confirm加了）？

@chenjiahan
Copy link
Member

  1. 可以加
  2. 加参数问题不大，不会有负面影响
  3. 建议加到 getEventParams 里

@wjw-gavin wjw-gavin marked this pull request as ready for review November 30, 2022 10:24
@chenjiahan chenjiahan merged commit b423dec into youzan:main Nov 30, 2022
@chenjiahan
Copy link
Member

🎉

@wjw-gavin wjw-gavin deleted the feat_picker_index branch November 30, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wjw-gavin @chenjiahan