feat(Rate): add clearable prop #11969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenjiahan
reviewed
Jun 17, 2023
packages/vant/src/rate/Rate.tsx
Outdated
| @@ -197,6 +200,16 @@ export default defineComponent({ | |||
| preventDefault(event); | |||
| select(getScoreByPosition(clientX, clientY)); | |||
| } | |||
|
|
|||
| const TAP_THRESHOLD_DISTANCE = 3; | |||
There was a problem hiding this comment.
src/image-preview/ImagePreviewItem.tsx 里有一个类似作用的常量，const TAP_OFFSET = 5;，可以考虑统一放到 src/utils/constant.ts 里维护。
这里阈值 3px 小了一点，我看了下社区里比较常用的是设置为 5px~10px，Vant 里可以统一用 5px
chenjiahan
approved these changes
Jun 18, 2023
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #11968