Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for encrypted tasks #1008

Merged
merged 4 commits into from Jan 29, 2024
Merged

Fix for encrypted tasks #1008

merged 4 commits into from Jan 29, 2024

Conversation

bartvanb
Copy link
Member

@bartvanb bartvanb commented Jan 25, 2024

Issue was that the request from the central container did not go through the proper specialized route in the proxy server, so the results were not decrypted when they got to the central part of the algorithm.

Also, a few things had to be fixed/renamed in the proxy routes (they had thus never been used on v4 and contained minor bugs).

Finally, improved a check in the CLI for encryption

Fix #955

…gorithm container properly

These requests were not picked up by the specialized proxy server endpoint due to the argument included in the route
The former does not make sense to have because in the run endpoint there are no results to decrypt
Copy link
Contributor

@frankcorneliusmartin frankcorneliusmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartvanb bartvanb merged commit 4a0b021 into main Jan 29, 2024
6 checks passed
@bartvanb bartvanb deleted the hotfix/encrypted-task-fix branch January 29, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Encryption support in algorithm client is missing
2 participants