Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add algo stores to server from config #1156

Merged
merged 9 commits into from Apr 4, 2024

Conversation

bartvanb
Copy link
Member

This PR makes sure that when config contains:

algorithm_stores:
  - name: Community store
    url: https://store.cotopaxi.vantage6.ai

That the community store will be available for all collaborations in that server

Copy link
Contributor

@wbaccinelli wbaccinelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice!
I put a few minor comments, and I have two highlights:

  • I have just a doubt about the concept of having the server whitelisting themselves, because it sounds like bypassing the check of the store admin.
  • I get now an error that I reported in the comments. I'm requesting the change just for this one (if it's not a mistake that I am making)

Copy link
Contributor

@wbaccinelli wbaccinelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly!

Copy link
Contributor

@wbaccinelli wbaccinelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added just a very last comment :)

Comment on lines 162 to 164
algo_store_url = algo_store_url.replace(
"localhost", "host.docker.internal"
).replace("127.0.0.1", "host.docker.internal")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this should then be changed like this

Suggested change
algo_store_url = algo_store_url.replace(
"localhost", "host.docker.internal"
).replace("127.0.0.1", "host.docker.internal")
algo_store_url = algo_store_url.replace(
"localhost", host_uri
).replace("127.0.0.1", host_uri)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha thanks for spotting, that was a rather stupid mistake :-)

@bartvanb bartvanb merged commit fdf4253 into release/4.4 Apr 4, 2024
3 checks passed
@bartvanb bartvanb deleted the feature/add-algo-stores-to-server-from-config branch April 4, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants