Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed username field from password recovery form #1266

Merged

Conversation

frankcorneliusmartin
Copy link
Contributor

Fixes #1121

Note that I left in the code that can handle both email and username. I felt like leaving it in in case we had a change or hearth. But let me know if it needs te be removed.

Copy link
Member

@bartvanb bartvanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works but it leaves unused code. The typescript file should be adjusted as well to remove the username from the form, and then also the call to the API should be adjusted.

@frankcorneliusmartin
Copy link
Contributor Author

frankcorneliusmartin commented May 15, 2024

image
This wil remain as this is a server response.

  • I could not get rid of the if (emailValue) { part... Is there a better way to do it? We know there always will be a string (even an email formatted one now).
  • I removed the FormBuilder.group method call as it is deprecated, see https://angular.io/api/forms/FormBuilder#group

@bartvanb bartvanb merged commit 5b5fbdc into release/4.5 May 22, 2024
3 checks passed
@bartvanb bartvanb deleted the feature/remove-username-from-password-recovery-ui branch May 22, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Make more clear 'username' or 'email' alternative in password recovery
2 participants