Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new endpoint /vpn/algorithm/addresses to retrieve the IP addres… #501

Merged
merged 4 commits into from Feb 9, 2023

Conversation

bartvanb
Copy link
Member

…ses + ports of other algorithm containers in the same task

Fix #499

@bartvanb bartvanb changed the base branch from dev3 to release/v3.8 January 26, 2023 16:00
Copy link
Contributor

@frankcorneliusmartin frankcorneliusmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

However shouldnt we return an error code when no VPN is configured?

vantage6-server/vantage6/server/resource/__init__.py Outdated Show resolved Hide resolved
…s an endpoint, they should get Bad Request, not Forbidden status
Copy link
Contributor

@frankcorneliusmartin frankcorneliusmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@frankcorneliusmartin frankcorneliusmartin merged commit e6d4a15 into release/v3.8 Feb 9, 2023
@frankcorneliusmartin frankcorneliusmartin deleted the feature/endpoint-vpn-addresses branch February 9, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants