Feature/updated algorithm client #510

bartvanb · 2023-01-27T09:34:34Z

…ses + ports of other algorithm containers in the same task

… subtasks/parent tasks are included

…y port label

…erClient

…ng improvement

…iner doesnt try to refresh its token

frankcorneliusmartin

Nice solution with the use_new_client.
Maybe something that we can in the decorator as well ^.^
@AlgorithmClient(version=1)

Ofc. I did not check the VPN changes

docs/algorithms/classic_tutorial.rst

vantage6-client/vantage6/client/algorithm_client.py

frankcorneliusmartin

lgtm

bartvanb added 9 commits January 19, 2023 17:13

Added new endpoint /vpn/algorithm/addresses to retrieve the IP addres…

8e6cca3

…ses + ports of other algorithm containers in the same task

Include task_id in endpoint to get ports, as that clarifies things if…

7f2a2f2

… subtasks/parent tasks are included

Add argument 'label' to /vpn/algorithm/addresses to allow filtering b…

fc5476f

…y port label

Added new AlgorithmClient, which is an updated version of the Contain…

82de02b

…erClient

Updated docs for new client name

3de8299

Moved around subclasses of AlgorithmClient to more logical order

eeeb2c2

Add option to use new algorithmClient in algorithms, and some docstri…

5e21335

…ng improvement

For algorithmClient, redefine standard request function so that conta…

e8f42d3

…iner doesnt try to refresh its token

Updated docstrings

e326934

bartvanb requested a review from frankcorneliusmartin January 27, 2023 09:34

frankcorneliusmartin requested changes Jan 27, 2023

View reviewed changes

Addressed review comments for new algorithm client.

898dd00

bartvanb requested a review from frankcorneliusmartin January 31, 2023 10:59

Resolve part of the codacy style errors

7531201

frankcorneliusmartin approved these changes Feb 9, 2023

View reviewed changes

frankcorneliusmartin merged commit 8a75a02 into release/v3.8 Feb 9, 2023

frankcorneliusmartin deleted the feature/updated-algorithm-client branch February 9, 2023 13:38

Provide feedback