Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/get algorithm addresses children or parent #610

Merged

Conversation

bartvanb
Copy link
Member

New addition to /vpn/algorithm/addresses.

Previously, the algorithm developer would be presented with a list of addresses from which they had to determine which tasks were parents/children/same level.
Now, there are new utility functions to help algo developers do this with a simple function call.

This makes it easier for the algorithm developer to figure out which of the IP addresses is the central container
…ld tasks

This is a common use case: a child task wants to communicate to the parent or a parent to their children. Previously, the algorithm developer would then be presented with a dictionary from which they had to determine which tasks were parents/children/same level. Now, this can be done by a simple function call
Copy link
Contributor

@frankcorneliusmartin frankcorneliusmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, let merge this to 3.9 and not directly to main

@frankcorneliusmartin frankcorneliusmartin changed the base branch from main to release/3.9 March 28, 2023 09:21
@bartvanb bartvanb merged commit 696b2b0 into release/3.9 Mar 28, 2023
2 checks passed
@bartvanb bartvanb deleted the feature/get-algorithm-addresses-children-or-parent branch March 28, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To Test
Development

Successfully merging this pull request may close these issues.

None yet

2 participants