On systems with older iptables (iptables-legacy), VPN configuration i… #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s fixed by running iptables-legacy commands if regular fails
frankcorneliusmartin
approved these changes
Sep 6, 2023
There was a problem hiding this comment.
I think now the default is to use the outdated iptables command first right? In that case the fix should not be removed eventually, but the code should be updated to work with the new iptables command. If this is the case we should create an issue for this before merging this.
|
No actually the new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s fixed by running iptables-legacy commands if regular fails
Caused by the changes in #725 - apparently we now only fixed it for systems with
iptablesand it no longer works for systems where the actual iptables rules are iniptables-legacy