Fix connection issues of node when server is restarted without consta… #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Whether or not the connection is authenticated | ||
| """ | ||
| if not authenticated: | ||
| return |
There was a problem hiding this comment.
Shouldn't we log this? I guess the socketio library keeps retrying?
There was a problem hiding this comment.
In a new commit I added explanation why no message is needed here
frankcorneliusmartin
approved these changes
Oct 5, 2023
frankcorneliusmartin
deleted the
hotfix/nodes-do-not-reconnect-wo-constant-jwt
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nt jwt key
Fix #840
Note that in the process, I'm also now preventing that nodes try to sync their tasks when they are not authenticated - this would happen if the socket connection is re-established when JWT key has been changed, which led to many errors of the node trying to sync the task list.