Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed broken data loading in mockClient #881

Merged
merged 1 commit into from Oct 2, 2023
Merged

Fixed broken data loading in mockClient #881

merged 1 commit into from Oct 2, 2023

Conversation

bartvanb
Copy link
Member

  • Handle pd.Dataframe properly
  • correct 'type' to 'db_type'

Fix #872

@bartvanb
Fixed broken data loading in mockClient
bc61d3e 
- Handle pd.Dataframe properly
- correct 'type' to 'db_type'
frankcorneliusmartin
frankcorneliusmartin approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@frankcorneliusmartin frankcorneliusmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frankcorneliusmartin frankcorneliusmartin merged commit ae00933 into main Oct 2, 2023
5 checks passed
@frankcorneliusmartin frankcorneliusmartin deleted the hotfix/broken-data-loading-mockclient branch October 2, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankcorneliusmartin frankcorneliusmartin frankcorneliusmartin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Passing dataframes to the AlgorithmMockClient broke in 4.0
2 participants
@bartvanb @frankcorneliusmartin