Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/column name endpoint #908

Merged
merged 4 commits into from Oct 19, 2023
Merged

Feature/column name endpoint #908

merged 4 commits into from Oct 19, 2023

Conversation

bartvanb
Copy link
Member

Fix #778

frankcorneliusmartin
frankcorneliusmartin approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@frankcorneliusmartin frankcorneliusmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor changes needed

vantage6-node/vantage6/node/docker/docker_manager.py Show resolved Hide resolved
vantage6-server/vantage6/server/resource/ui/column.py Outdated Show resolved Hide resolved
vantage6-common/vantage6/common/globals.py Outdated Show resolved Hide resolved
@frankcorneliusmartin frankcorneliusmartin merged commit 3889e9f into release/4.1 Oct 19, 2023
2 of 3 checks passed
@frankcorneliusmartin frankcorneliusmartin deleted the feature/column-name-endpoint branch October 19, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankcorneliusmartin frankcorneliusmartin frankcorneliusmartin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bartvanb @frankcorneliusmartin