Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the check for which algorithm container ports are occupied wh… #982

Merged
merged 2 commits into from Jan 17, 2024
Merged

Improve the check for which algorithm container ports are occupied wh… #982

merged 2 commits into from Jan 17, 2024

Conversation

bartvanb
Copy link
Member

Fix #966

@bartvanb
Improve the check for which algorithm container ports are occupied wh…
a823e79 
…en starting a algorithm with VPN

This resolves an issue where iptables gives warnings (in the observed case about iptables-legacy, which is irrelevant as this is a container that we control)
@bartvanb bartvanb self-assigned this Jan 16, 2024
frankcorneliusmartin
frankcorneliusmartin approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@frankcorneliusmartin frankcorneliusmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. But I dont understand how this situation could exist? Do nodes publish non numerical ports?

@bartvanb
Copy link
Member Author

No, what happens it that when both iptables and iptables-legacy are installed, the node will give a warning that iptables-legacy is also installed and that warning is a string - that's how Harm got his error.

(We could consider trying to remove iptables-legacy from the client image but it seems that it is installed together with iptables and probably it will disappear at some point)

@bartvanb bartvanb merged commit 1669b28 into release/4.2 Jan 17, 2024
3 checks passed
@bartvanb bartvanb deleted the bugfix/vpn-check-occupied-ports-improve branch January 17, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankcorneliusmartin frankcorneliusmartin frankcorneliusmartin approved these changes

Assignees

@bartvanb bartvanb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bartvanb @frankcorneliusmartin