splat metadata #58
Merged
splat metadata #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs and better tests
|
Very nice work, thx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
winstonallows logging loose metadata that is not just a JSON object. However, due to the constraints of Elasticsearch'sdynamicfield for object datatypes,winston-elasticsearchhas to enforce (at least for the default Elasticsearch mapping template) thatmetais an object. Currently it does not. This leads to lost logs if just a single log has a concrete value rather than an object in metadata, because Elasticsearch will error out the bulk request.This PR just splats into a meta object which gets passed to the transformer.