Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use object assign for node6 #59

Merged
merged 2 commits into from
Jul 7, 2018

Conversation

arjd4science
Copy link
Contributor

  • improves coverage by removing unused functions and condensing lines
  • uses Object.assign instead of ... rest operator to support node6

@coveralls
Copy link

coveralls commented Jul 6, 2018

Coverage Status

Coverage increased (+5.0%) to 82.963% when pulling abe83f3 on arjd4science:use-object-assign-for-node6 into 4eafeb1 on vanthome:master.

@vanthome
Copy link
Owner

vanthome commented Jul 7, 2018

Goal is not to support node6 with this module but I will accept it. Also I'm not so happy that you removed the query methods but when needed I can restore them. I want to use them when winston 3 supports querying again.

@vanthome vanthome merged commit d232eba into vanthome:master Jul 7, 2018
@arjd4science arjd4science deleted the use-object-assign-for-node6 branch July 8, 2018 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants