Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: transformer template support json path #349

Merged
merged 1 commit into from
Dec 17, 2022

Conversation

xdlbdy
Copy link
Contributor

@xdlbdy xdlbdy commented Dec 16, 2022

Signed-off-by: delu delu.xu@linkall.com

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary

What is changed and how does it work?

  • transformer template support event attribute <$.attributeName> and data <$.data.key>
  • fix newArg event attribute such as $.dataxxx as event data bug

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Signed-off-by: delu <delu.xu@linkall.com>
@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #349 (04c7164) into main (09f3748) will increase coverage by 0.39%.
The diff coverage is 62.56%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #349      +/-   ##
==========================================
+ Coverage   62.72%   63.12%   +0.39%     
==========================================
  Files         133      144      +11     
  Lines       12128    13176    +1048     
==========================================
+ Hits         7607     8317     +710     
- Misses       3977     4274     +297     
- Partials      544      585      +41     
Impacted Files Coverage Δ
internal/controller/eventbus/block/block.go 56.09% <0.00%> (ø)
internal/controller/eventbus/server/instance.go 72.04% <ø> (ø)
internal/controller/eventbus/server/manager.go 66.66% <ø> (ø)
internal/controller/trigger/storage/secret.go 48.48% <ø> (ø)
...nternal/controller/trigger/storage/subscription.go 54.71% <ø> (ø)
...ernal/controller/trigger/storage/trigger_worker.go 63.41% <ø> (ø)
...rnal/primitive/interceptor/errinterceptor/error.go 0.00% <0.00%> (ø)
.../primitive/interceptor/memberinterceptor/member.go 0.00% <0.00%> (ø)
internal/primitive/vanus/id.go 19.84% <0.00%> (-0.49%) ⬇️
internal/raft/log/wal.go 100.00% <ø> (ø)
... and 82 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5c27d3...04c7164. Read the comment docs.

Copy link
Contributor

@wenfengwang wenfengwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenfengwang wenfengwang merged commit b8ab5ef into vanus-labs:main Dec 17, 2022
wenfengwang pushed a commit that referenced this pull request Mar 23, 2023
Signed-off-by: delu <delu.xu@linkall.com>

Signed-off-by: delu <delu.xu@linkall.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants