Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement function "check_custom_values" #440

Merged
merged 5 commits into from
Feb 21, 2023

Conversation

dhanusaputra
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #428

Problem Summary

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Copy link
Contributor

@xdlbdy xdlbdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xdlbdy xdlbdy merged commit e8da787 into vanus-labs:main Feb 21, 2023
@dhanusaputra dhanusaputra deleted the function-check-custom-values branch February 22, 2023 02:28
wenfengwang pushed a commit that referenced this pull request Mar 23, 2023
* feat: implement function "check_custom_values"

* rename

* fix lint

* fix comment

* fix review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Good First Issues]: implement function "check_custom_values" - 7 points
2 participants