feat(store): warm file after create #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Yin <ywhjames@hotmail.com>
Signed-off-by: James Yin <ywhjames@hotmail.com>
ifplusor
force-pushed
the
perf-append
branch
2 times, most recently
from
a785df3
to
52eae4c
Compare
Signed-off-by: James Yin <ywhjames@hotmail.com>
Signed-off-by: James Yin <ywhjames@hotmail.com>
Signed-off-by: James Yin <ywhjames@hotmail.com>
ifplusor
force-pushed
the
perf-append
branch
from
52eae4c
to
83d3217
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #452 +/- ##
==========================================
- Coverage 57.71% 57.07% -0.64%
==========================================
Files 180 184 +4
Lines 14614 15001 +387
==========================================
+ Hits 8434 8562 +128
- Misses 5552 5807 +255
- Partials 628 632 +4
Continue to review full report at Codecov.
|
wenfengwang
suggested changes
Feb 28, 2023
wenfengwang
pushed a commit
that referenced
this pull request
Mar 23, 2023
* fix(store): open wal without recovery callback Signed-off-by: James Yin <ywhjames@hotmail.com> * fix(store): io uring Signed-off-by: James Yin <ywhjames@hotmail.com> * feat(store): warm file after create Signed-off-by: James Yin <ywhjames@hotmail.com> * feat: support handoff on blocking queue Signed-off-by: James Yin <ywhjames@hotmail.com> * feat(store): use blocking queue in wal appending Signed-off-by: James Yin <ywhjames@hotmail.com> --------- Signed-off-by: James Yin <ywhjames@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Improve file IO performance.
Issue Number: None
Problem Summary
What is changed and how does it work?
Warm file after create it.
Check List
Tests