Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(timer): use eventbus id instead of name #505

Merged
merged 1 commit into from
Mar 9, 2023
Merged

feat(timer): use eventbus id instead of name #505

merged 1 commit into from
Mar 9, 2023

Conversation

hwjiangkai
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@hwjiangkai
feat(timer): use eventbus id instead of name
67c0aff 
Signed-off-by: jyjiangkai <jyjiangkai@163.com>
wenfengwang
wenfengwang approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@wenfengwang wenfengwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenfengwang wenfengwang merged commit f112a05 into main Mar 9, 2023
@wenfengwang wenfengwang deleted the timer branch March 11, 2023 08:31
wenfengwang pushed a commit that referenced this pull request Mar 23, 2023
@hwjiangkai
feat(timer): use eventbus id instead of name (#505)
cbd458d 
Signed-off-by: jyjiangkai <jyjiangkai@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenfengwang wenfengwang wenfengwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hwjiangkai @wenfengwang