Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add toolbox and fix eventbus name can be same #556

Merged
merged 12 commits into from
Mar 20, 2023
Merged

Conversation

wenfengwang
Copy link
Contributor

@wenfengwang wenfengwang commented Mar 18, 2023

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary

add toolbox and fix eventbus name can be same

What is changed and how does it work?

kubectl run --rm -i -t --image=public.ecr.aws/vanus/toolbox -n vanus -- bash

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    quickstart
  • No code

@codecov
Copy link

codecov bot commented Mar 18, 2023

Codecov Report

Merging #556 (843930b) into main (ee76217) will decrease coverage by 1.23%.
The diff coverage is 48.05%.

❗ Current head 843930b differs from pull request most recent head 2647402. Consider uploading reports for the commit 2647402 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #556      +/-   ##
==========================================
- Coverage   57.07%   55.84%   -1.23%     
==========================================
  Files         190      191       +1     
  Lines       15191    15559     +368     
==========================================
+ Hits         8670     8689      +19     
- Misses       5884     6219     +335     
- Partials      637      651      +14     
Impacted Files Coverage Δ
internal/controller/eventbus/block/block.go 35.93% <0.00%> (-16.70%) ⬇️
internal/controller/eventbus/block/selector.go 91.66% <ø> (-8.34%) ⬇️
internal/controller/trigger/storage/storage.go 0.00% <ø> (ø)
internal/controller/trigger/worker/policy.go 100.00% <ø> (ø)
internal/gateway/proxy/deadletter.go 0.00% <0.00%> (ø)
internal/primitive/cel/cel.go 68.57% <0.00%> (ø)
...rnal/primitive/interceptor/errinterceptor/error.go 0.00% <0.00%> (ø)
.../primitive/interceptor/memberinterceptor/member.go 0.00% <0.00%> (ø)
internal/primitive/queue/queue.go 87.87% <ø> (ø)
internal/primitive/transform/action/action.go 11.94% <ø> (ø)
... and 70 more

... and 39 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f6aea7...2647402. Read the comment docs.

if err != nil {
return nil, err
}
ns.cache.Store(id, pb)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when the namespace is deleted the cache need to be cleaned, so if uses id it can't cache?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't a good idea to handle this, I will open an issue to track this

pkg/cluster/eventbus.go Outdated Show resolved Hide resolved
build/all-in-one/Dockerfile Show resolved Hide resolved
@wenfengwang wenfengwang merged commit 0f7b4f7 into main Mar 20, 2023
@wenfengwang wenfengwang mentioned this pull request Mar 20, 2023
@wenfengwang wenfengwang deleted the toolbox branch March 23, 2023 03:48
wenfengwang added a commit that referenced this pull request Mar 23, 2023
* build: add vanus toolbox

* update

* update

* update

* fix

* update

* update

* update

* update

* update

* fix lint

* add compatibility of older than v0.7.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants