-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add toolbox and fix eventbus name can be same #556
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #556 +/- ##
==========================================
- Coverage 57.07% 55.84% -1.23%
==========================================
Files 190 191 +1
Lines 15191 15559 +368
==========================================
+ Hits 8670 8689 +19
- Misses 5884 6219 +335
- Partials 637 651 +14
... and 39 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
pkg/cluster/namespace.go
Outdated
if err != nil { | ||
return nil, err | ||
} | ||
ns.cache.Store(id, pb) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when the namespace is deleted the cache need to be cleaned, so if uses id it can't cache?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't a good idea to handle this, I will open an issue to track this
* build: add vanus toolbox * update * update * update * fix * update * update * update * update * update * fix lint * add compatibility of older than v0.7.0
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary
add toolbox and fix eventbus name can be same
What is changed and how does it work?
Check List
Tests
quickstart