Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store): unexpected compaction after restart #603

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

ifplusor
Copy link
Collaborator

@ifplusor ifplusor commented Jun 1, 2023

What problem does this PR solve?

Issue Number: None

Fix #437 is incomplete.

Problem Summary

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Signed-off-by: James Yin <ywhjames@hotmail.com>
@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #603 (61c7097) into main (ee76217) will decrease coverage by 2.52%.
The diff coverage is 46.82%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #603      +/-   ##
==========================================
- Coverage   57.07%   54.55%   -2.52%     
==========================================
  Files         190      211      +21     
  Lines       15191    17036    +1845     
==========================================
+ Hits         8670     9294     +624     
- Misses       5884     7038    +1154     
- Partials      637      704      +67     
Impacted Files Coverage Δ
internal/controller/trigger/storage/storage.go 0.00% <ø> (ø)
...ernal/controller/trigger/validation/subscripton.go 66.12% <ø> (-3.17%) ⬇️
internal/controller/trigger/worker/manager.go 85.76% <ø> (+0.83%) ⬆️
internal/controller/trigger/worker/policy.go 100.00% <ø> (ø)
internal/controller/trigger/worker/scheduler.go 71.01% <ø> (+1.01%) ⬆️
internal/controller/trigger/worker/worker.go 78.45% <ø> (-1.55%) ⬇️
internal/gateway/config.go 60.60% <ø> (-0.51%) ⬇️
internal/gateway/gateway.go 57.64% <ø> (-10.03%) ⬇️
internal/gateway/proxy/auth.go 0.00% <ø> (ø)
internal/gateway/proxy/deadletter.go 0.00% <ø> (ø)
... and 70 more

... and 59 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43db43b...61c7097. Read the comment docs.

Copy link
Contributor

@xdlbdy xdlbdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ifplusor ifplusor merged commit 44bbb30 into vanus-labs:main Jun 1, 2023
3 of 5 checks passed
@ifplusor ifplusor deleted the fix-compact branch June 1, 2023 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants