New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data loader #85
Merged
Merged
Data loader #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willgraf
reviewed
May 13, 2020
willgraf
reviewed
May 13, 2020
willgraf
reviewed
May 13, 2020
willgraf
reviewed
May 13, 2020
willgraf
reviewed
May 13, 2020
willgraf
reviewed
May 13, 2020
willgraf
requested changes
May 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor changes.
Additionally, there's a lot of TODOs to add a logger. Is there a reason to not do it in this PR?
ngreenwald
reviewed
May 14, 2020
willgraf
reviewed
May 14, 2020
willgraf
approved these changes
May 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an elementary data loader that is built to read from the CellNet data ontology. It allows for human-readable calls to build raw data and packages it with the accompanying metadata files to prepare it for submission to crowdsourcing platforms.
It represents the first step toward a complete overhaul of our data pipeline, and, as such, will undergo several changes once DeepCell Datasets is closer to being a mature repo.
There are also miscellaneous critical updates to inits and testing that bring the current toolbox repo closer to maturity.