Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update example data #88

Merged
merged 6 commits into from Jun 5, 2020
Merged

update example data #88

merged 6 commits into from Jun 5, 2020

Conversation

ngreenwald
Copy link
Collaborator

Removes the old example data and adds new data that follows the raw data ontology.

@epao111, I have the wrong metadata file in the A549 folder as a placeholder. Could you send me the right one for the 3D and 2D data?

@ngreenwald
Copy link
Collaborator Author

Okay, I updated the 2D metadata with the correct metadata file from Ed. We have a placeholder metadata file for the 3D data while Ed is figuring out how to properly represent stacked data.

@MekWarrior, your call if you want to merge with the placeholder or wait until you and Ed hash our the 3D metadata file.

@ngreenwald
Copy link
Collaborator Author

Alright, added the new metadata file

@ngreenwald ngreenwald requested a review from willgraf June 4, 2020 17:48
Copy link
Contributor

@willgraf willgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really any code changes here. Maybe we can find some example images that are kB instead of MB? I'm usually not a huge fan of saving data in the code repo.

@MekWarrior
Copy link
Collaborator

@willgraf is it worth adapting some of the keras-style download functions to this repo for the data? There's two points to the data being here: one is for test/training purposes and the other is to illustrate the ontology we expect. Perhaps we should even state that ontology expressly in the readme?

@MekWarrior MekWarrior mentioned this pull request Jun 5, 2020
@MekWarrior
Copy link
Collaborator

Further work needed to close #57, but it looks good to pull this in.

@MekWarrior MekWarrior merged commit 57c59f4 into master Jun 5, 2020
@MekWarrior MekWarrior deleted the update_example_data branch June 5, 2020 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants