Update README.md #89
Merged
Update README.md #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docker base image you're using is
Is this something that should even be included in the docs? It's a useful hack for development, but not necessary for using it. |
|
Okay, the scripts are actually located in /site-packages, not /dist-packages. Maybe because of how it's installed? Happy to remove if you don't think it's necessary |
MekWarrior
requested changes
May 22, 2020
geneva-miller
suggested changes
May 22, 2020
|
Awesome, let me know what you think of the new version |
geneva-miller
approved these changes
Jun 3, 2020
|
Looks good. The only thing I think should be added is a description of our ontology. But that is covered as outstanding in #57 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the readme to reflect the current workflow. Let me know what areas could use further improvement.
@willgraf, one question for you. The current code to mount the codebase doesn't actually work.
-v $PWD/caliban_toolbox:/usr/local/lib/python3.5/dist-packages/caliban_toolbox/The instructions were probably copied from deepcell-tf. However, in this docker there's nothing inside dist-packages, so mounting it does nothing.
Is there somewhere else I should be looking for docker's version of the scripts?