Erode dilate contour master #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willgraf
requested changes
Dec 23, 2020
Co-authored-by: willgraf <7930703+willgraf@users.noreply.github.com>
Co-authored-by: willgraf <7930703+willgraf@users.noreply.github.com>
Co-authored-by: willgraf <7930703+willgraf@users.noreply.github.com>
geneva-miller
approved these changes
Dec 23, 2020
willgraf
approved these changes
Dec 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR is a hotfix for three additional actions in DeepCell Label: erode, dilate, and active contour. The names of these actions on the frontend are shrink, expand, and autofit, respectively. The keybinds are q (for erode), Q (for dilate), and m (for autofit), then a Space to confirm the action. They are only available in whole-label mode and require a single label to be selected.
A test instance of this PR is available here: new-actions-test.q2qqtvkafv.us-east-2.elasticbeanstalk.com
Why
These actions will allow for cleaner, faster adjustment of labels without a brush.
This PR does not include tests for the new actions, but the tests are written in branch erode-dilate-active-contour (see commit dfde2d2), as these tests use the new DummyLoader features from the file-loader branch. You can see on the linked commit that the tests are passing for these actions. We're aiming to merge in these actions without the rest of the file-loader branch so that we can start using them with Anolytics without any hiccups the file loaders might cause. I'll add these tests to the file-loader branch as soon as this is merged in.