Fix action history initialization to change frames correctly #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willgraf
reviewed
Jan 11, 2021
willgraf
approved these changes
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This is a quick bug fix that affects reloading the action history when revisiting a project URL. The constructor for a ChangeFrame action changed between #212 and #214, but did not change in initializeActionHistory, causing the frames to not change while undoing past actions after reloading the page.
One issue highlighted by this fix is that initializeActionHistory does not switch between features when past actions occurred on different features. I made an issue #220 to document this.
Why
When actions occur on different frames, we should switch to the frame where the action occurs before undoing it so that the changes are visible.