New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable option for fixed size crops in get_image_features #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pens if the norm flag is true
msschwartz21
changed the title
Dvv/fixed crop
Enable option for fixed size crops in get_image_features
Jun 3, 2022
msschwartz21
requested changes
Jun 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to suggest changes to make it so that props_padded does not get calculated unnecessarily, but you may need to check that all of the suggestions work correctly.
Co-authored-by: Morgan Schwartz <msschwartz21@gmail.com>
Co-authored-by: Morgan Schwartz <msschwartz21@gmail.com>
Co-authored-by: Morgan Schwartz <msschwartz21@gmail.com>
Co-authored-by: Morgan Schwartz <msschwartz21@gmail.com>
Co-authored-by: Morgan Schwartz <msschwartz21@gmail.com>
Co-authored-by: Morgan Schwartz <msschwartz21@gmail.com>
msschwartz21
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add a flag to get_image_features to allow for doing fixed sized crops rather than crop and resize.
Why
Crop and resize removes information about cell size, which is useful for cell tracking and also learning dynamic representations of cell behavior.