Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade tf-serving chart to 0.3.0 for application version 0.4.0 #392

Merged
merged 5 commits into from
Dec 3, 2020
Merged

Upgrade tf-serving chart to 0.3.0 for application version 0.4.0 #392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
733b1b8
Remove CLOUD_PROVIDER and merge BUCKET env vars for chart version 0.3.0
willgraf Nov 25, 2020
26d5ad3
Update chart version to 0.3.0 and image version to 0.4.0
willgraf Nov 25, 2020
ee87f94
Use default STORAGE_BUCKET with instructions to uncomment to override.
willgraf Nov 25, 2020
30a020d
Use empty strings as AWS credentials and deepcell-models as default b…
willgraf Nov 25, 2020
52b8c83
Merge branch 'stable' into tf-serving-0.4.0
willgraf Dec 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion conf/charts/tf-serving/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v1
name: tf-serving
version: 0.2.0
version: 0.3.0
#kubeVersion: ^1.9.8
description: This helm chart provides the Tensorflow-serving backend functionality of the Deepcell application.
keywords:
Expand Down
8 changes: 3 additions & 5 deletions conf/charts/tf-serving/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,15 +67,13 @@ env:
MAX_ENQUEUED_BATCHES: 512
GRPC_CHANNEL_ARGS: ""
MODEL_PREFIX: models
CLOUD_PROVIDER: '{{ env "CLOUD_PROVIDER" | default "aws" }}'
TF_CPP_MIN_LOG_LEVEL: 0
TF_SESSION_PARALLELISM: 0
MONITORING_CONFIG_FILE: /config/monitoring_config.txt
PROMETHEUS_MONITORING_ENABLED: "true"
PROMETHEUS_MONITORING_PATH: /monitoring/prometheus/metrics

secrets:
AWS_ACCESS_KEY_ID: "change_me"
AWS_SECRET_ACCESS_KEY: "change_me"
AWS_S3_BUCKET: "change_me"
GCLOUD_STORAGE_BUCKET: "change_me"
AWS_ACCESS_KEY_ID: ""
AWS_SECRET_ACCESS_KEY: ""
STORAGE_BUCKET: gs://deepcell-models
16 changes: 9 additions & 7 deletions conf/helmfile.d/0310.tf-serving.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,13 @@ releases:
vendor: vanvalenlab
default: true
chart: '{{ env "CHARTS_PATH" | default "/conf/charts" }}/tf-serving'
version: 0.2.0
version: 0.3.0
values:
- replicas: 0

image:
repository: vanvalenlab/kiosk-tf-serving
tag: 0.3.0
tag: 0.4.0

configWriter:
mountedVolume:
Expand All @@ -37,7 +37,7 @@ releases:

image:
repository: vanvalenlab/kiosk-tf-serving-config-writer
tag: 0.3.0
tag: 0.4.0
pullPolicy: IfNotPresent

resources:
Expand Down Expand Up @@ -102,7 +102,6 @@ releases:
MAX_ENQUEUED_BATCHES: 512
GRPC_CHANNEL_ARGS: ""
MODEL_PREFIX: models
CLOUD_PROVIDER: '{{ env "CLOUD_PROVIDER" | default "aws" }}'
TF_CPP_MIN_LOG_LEVEL: 0
TF_SESSION_PARALLELISM: 0
MONITORING_CONFIG_FILE: /config/monitoring_config.txt
Expand All @@ -112,6 +111,9 @@ releases:
secrets:
AWS_ACCESS_KEY_ID: '{{ env "AWS_ACCESS_KEY_ID" | default "NA" }}'
AWS_SECRET_ACCESS_KEY: '{{ env "AWS_SECRET_ACCESS_KEY" | default "NA" }}'
AWS_S3_BUCKET: '{{ env "AWS_S3_BUCKET" | default "NA" }}'
# GCLOUD_STORAGE_BUCKET: '{{ env "CLOUDSDK_BUCKET" | default "NA" }}'
GCLOUD_STORAGE_BUCKET: deepcell-models
# Uncomment to override the default models.
{{ if eq (env "CLOUD_PROVIDER" | default "aws") "aws" }}
# STORAGE_BUCKET: 's3://{{ env "AWS_S3_BUCKET" | default "NA" }}'
{{ else }}
# STORAGE_BUCKET: 'gs://{{ env "CLOUDSDK_BUCKET" | default "NA" }}'
{{ end }}