Bugfix: If get_redis_hash finds an invalid key, put it back in the qu…

…eue. (#57) * if a key is invalid for some reason, put it back instead of working on it. * update tests for get_redis_hash putback keys if invalid change
vanvalenlab · Aug 27, 2019 · c4883ae · c4883ae
1 parent 791293e
commit c4883ae
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/redis_consumer/consumers.py b/redis_consumer/consumers.py
@@ -118,7 +118,8 @@ def get_redis_hash(self):
             self.logger.warning('Found invalid hash in %s: `%s` with '
                                 'hvals: %s', self.queue, redis_hash,
                                 self.redis.hgetall(redis_hash))
-            self.redis.lrem(self.processing_queue, 1, redis_hash)
+            # self.redis.lrem(self.processing_queue, 1, redis_hash)
+            self._put_back_hash(redis_hash)
 
     def _handle_error(self, err, redis_hash):
         """Update redis with failure information, and log errors.

diff --git a/redis_consumer/consumers_test.py b/redis_consumer/consumers_test.py
@@ -206,7 +206,7 @@ def test_get_redis_hash(self):
 
         rhash = consumer.get_redis_hash()
         assert rhash == items[0]
-        assert redis_client.work_queue == []
+        assert redis_client.work_queue == items[1:]
         assert redis_client.processing_queue == items[0:1]
 
     def test_purge_processing_queue(self):