Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the license URL for some testing file copyrights. #118

Merged
merged 1 commit into from Jul 8, 2020
Merged

Conversation

willgraf
Copy link
Contributor

@willgraf willgraf commented Jul 8, 2020

No description provided.

@willgraf willgraf merged commit 75d8f07 into master Jul 8, 2020
@willgraf willgraf deleted the copyrights branch July 8, 2020 22:43
cdpavelchek pushed a commit that referenced this pull request Jul 10, 2020
* Improved testing coverage using fakeredis and pytest-mock (#117)

* install pytest-mock and replace monkeypatching with `mock` library.

* move testing reqs into requirements-test.txt and add 3.8 to test suite.

* update RedisClient tests to use fakeredis.

* directly patch boto3.client

* no need to alias google.cloud.storage in imports.

* Fix storage tests to use a Singleton dummy class instead of global variables.

* proper string fomatting using {} instead of %s

* move DummyStorage and DummyRedis into utils/testing_utils.py to DRY out the tests

* Update tests to use fakeredis client and fewer global variables.

* use save_output for ImageConsumer and MibiConsumer.

pass save_name into the function directly instead of calling HGETALL inside the save_output function.

* inherit from ImageFileConsumer to make better use of the pre/post-process functions.

* add keys for the mibi pre and postprocessing.

* adapt the mibi consumer tests to use the testing_utils.py helpers.

* remove unused imports.

* Fix a few license URLs. (#118)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant