Deprecate CLOUD_PROVIDER and require STORAGE_BUCKET to contain the bucket protocol #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set required=False and include DEPRECATED in help.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Infer the cloud provider based on the bucket URL (e.g.
gs://bucket-name/model-prefix). This requires just a single environment variable from the user.Set the default value of
STORAGE_BUCKETtogs://deepcell-modelsto allow a sensible default without requiring the environment variable at runtime.Update the README to reflect the split in the Docker containers
Use
pip install --no-cache-dirin the config writer container to reduce image size.