Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to pocketbase version 0.8.0-rc1 #3

Closed
wants to merge 2 commits into from

Conversation

perfalle
Copy link
Collaborator

I have tested email/password login, retrieving and updating items, but nothing more.

Copy link
Owner

@vaphes vaphes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, I really have no time to review the whole thing, so I will assume everything is ok and merge. :)

edit: As the checks have failed I will not merge right now. They probably failed due to some import missing maybe?

@vaphes vaphes self-requested a review November 1, 2022 20:16
There are still remaining errors:
F401 ... imported but unused
E501 line too long (... > 79 characters)
E722 do not use bare 'except'
@perfalle
Copy link
Collaborator Author

perfalle commented Nov 8, 2022

I had some trouble running flake the right way, but I fixed some errors.
There are still some errors showing up, but they are also where I did not change the code, so maybe my flake8 config is still wrong.

These types of errors still remain:
F401 ... imported but unused
E501 line too long (... > 79 characters)
E722 do not use bare 'except'

@vaphes
Copy link
Owner

vaphes commented Nov 8, 2022

I had some trouble running flake the right way, but I fixed some errors. There are still some errors showing up, but they are also where I did not change the code, so maybe my flake8 config is still wrong.

These types of errors still remain: F401 ... imported but unused E501 line too long (... > 79 characters) E722 do not use bare 'except'

Hey hey hey, thanks again for the update. As I started this project on a holiday, now I've got very little time to manage it so I added you as a collaborator.

As for the rc1 update: I've created a new branch for it so, if you can, please fork from there so we can work on the update without breaking the main branch.

See ya.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants