Add leaf tag suggestion #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md
Outdated
| return tag.serializer.serialize(ast: body).map(to: TemplateData.self) { body in | ||
| guard let rawBodyData = String(data: body.data, encoding: .utf8), | ||
| let bodyData = "{\(rawBodyData)}".data(using: .utf8), | ||
| let interpolations = try? JSONDecoder().decode([String:String].self, from: bodyData) else { |
There was a problem hiding this comment.
The Lingo interpolations are actually [String: Any], you can pass integers as well which are then used for pluralizations.
There was a problem hiding this comment.
Alright, now it supports integers as well.
code28
force-pushed
the
feature/leafTag
branch
from
79bde8e
to
7089711
Compare
nathanfallet
approved these changes
Apr 12, 2022
This was referenced Apr 13, 2022
|
Addressed in #14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Lingo in a website, using Leaf as a templating engine, a tag is helpful. Because Leaf tags don't support a dictionary as parameter, I parse the body of the tag as if it would be JSON format.
To not add Leaf as a dependency, I just put the code inside the README file. Since it's not as straight forward, as one could assume, I thought it might be nice to add this suggestion into this repository.