Fix email send response handling #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API returns 202 accepted, not 200 ok in the success case. To not break anything else, I've kept the check against .ok
melgu
force-pushed
the
Fix-response-handling
branch
from
b6cbbdb
to
8d2ac20
Compare
|
@Andrewangeta Hi! Can you (or someone else with write access) please have a look at the PR? Thank you 😊 |
|
Is this project still maintained? |
Andrewangeta
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
send(email:)call always throws, even in the success case. This is because the API returns202 accepted, not200 okin the success case.This is why I've added a check against
.accepted. To not break anything else, I've kept the check against.ok, but from my understanding it could be removed.