Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ephemeral keys #19

Merged
merged 4 commits into from
Oct 18, 2017
Merged

Ephemeral keys #19

merged 4 commits into from
Oct 18, 2017

Conversation

Andrewangeta
Copy link
Member

No description provided.

"created": self.created,
"expires": self.expires,
"livemode": self.isLive,
"secret": self.isLive

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Andrewangeta I think this is a bug. It should be "secret": self.secret. The iOS integration is crashing for me because of this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! Nice catch, will change right away.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good now. Circle CI is running integration tests but it’s safe to keep using.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Is the new version going out as a part of CI?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks again for implementing this. 🙇

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Andrewangeta I just updated and I still have the old code. I cleaned the package things before that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try again. Delete the build folder entirely, and make sure you have Xcode closed while you run update.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not tag it as 1.0.1?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.0.0 is a pretty round number lol, plus it Hans’t been pulled by in the few hours it’s been available really.

@Andrewangeta Andrewangeta deleted the ephemeralKeys branch January 19, 2018 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants