Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for nullable client secret. Although stripes documentation sugges… #54

Merged
merged 1 commit into from
Aug 9, 2018

Conversation

Andrewangeta
Copy link
Member

…ts that this value will always be apart of the request there's a scenario where it's not.

…ts that this value will always be apart of the request there's a scenario where it's not.
@baarde
Copy link
Contributor

baarde commented Aug 10, 2018

Imha, the root cause of the problem isn't that client_secret may be null but the fact that object could be card or bank_account (instead of source). StripeSourcesList tries to decode a StripeSource from Card or Bank Account object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants