Fix "Long-lasting job fails on EKS" (#124) #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I believe this is also related to #11 I'm running some tests against this to see if the latest release of the kubernetes python client is any better, but it looks like they have had many issues with refreshing stale credentials in the kubeconfig
If the latest client fixes this internally, all we'll need is a dependency version bump. Otherwise, I think this PR should do the trick. I do want to think through any implications of reloading the config for every API object on every API client retrieval. I don't think it should impact anything, but I do want to be sure prior to merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.