New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NetBox 2.9.3 compatibility issues #38
Conversation
The changes themselves look okay here, but just a few questions:
|
Yes, I believe all the changes here are related to the 2.9.3 compatibility fix. The NetBox configuration and required login models needs to be happened along with the updated ChangeLoggedModel path.
That's a good call. The plugin will probably break our fork which is currently at v2.8.5 if one bumps it to |
I think it probably is, but maybe just take a quick look around to see if you can quickly find anything on version pinning practices for netbox. If nothing obvious comes up, or the process to do it is more intensive than just some configuration, then yeah, a compatibility matrix is good and we can open an issue to tackle the version pinning separately. |
I'm opening #39 to tackle the version pinning separately as nothing good came up in my finding. |
This PR: