-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add initial integration tests for websocket client #79
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a question, but largely looks good.
The 500 responses from Synse Server are interesting. Are you able to get the logs from Synse Server for those errors? Or just a dump of all logs from Synse Server for the test run? It could be helpful to figure out whats going on. I think some of them might be related to unexpected input data, but even if it is an issue with how the client is preparing the data, I think Synse Server could have improved error responses to more clearly indicate that.
docker-compose -f compose/server.yml down | ||
|
||
.PHONY: test-integration-websocket | ||
test-integration-websocket: ## Run integration tests for websocket client |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we run the http and websocket integration tests separately? I'm sure there's a reason, just wanted to know
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a custom config for the emulator plugin to run the tests against. If we let the http and websocket integration tests run together, the http ones would go first and modify the config. Once the websocket ones run, we have to run the tests upon the modified config. It's confusing sometimes. So basically, letting them run separately makes sure that they are independent of each other and alway have a fresh start.
This PR:
Note that some of these tests are commented because of 500 response from server.