move ARG definitions to improve cache performance (#151)

vapor-ware · Apr 26, 2018 · 8a32ad8 · 8a32ad8
1 parent b3c418f
commit 8a32ad8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/dockerfile/release.dockerfile b/dockerfile/release.dockerfile
@@ -1,10 +1,6 @@
 FROM python:3.6-alpine
 LABEL maintainer="vapor@vapor.io"
 
-ARG BUILD_DATE
-ARG BUILD_VERSION
-ARG VCS_REF
-
 # Environment variables for built-in emulator configuration.
 ENV PLUGIN_DEVICE_CONFIG="/synse/emulator/config" \
     PLUGIN_CONFIG="/synse/emulator"
@@ -29,6 +25,10 @@ RUN set -e -x \
 
 # Image Metadata -- http://label-schema.org/rc1/
 # This is set after the dependency install so we can cache that layer
+ARG BUILD_DATE
+ARG BUILD_VERSION
+ARG VCS_REF
+
 LABEL org.label-schema.schema-version="1.0" \
       org.label-schema.build-date=$BUILD_DATE \
       org.label-schema.name="vaporio/synse-server" \

diff --git a/dockerfile/slim.dockerfile b/dockerfile/slim.dockerfile
@@ -1,10 +1,6 @@
 FROM python:3.6-alpine
 LABEL maintainer="vapor@vapor.io"
 
-ARG BUILD_DATE
-ARG BUILD_VERSION
-ARG VCS_REF
-
 COPY requirements.txt requirements.txt
 
 RUN set -e -x \
@@ -18,6 +14,10 @@ RUN set -e -x \
 
 # Image Metadata -- http://label-schema.org/rc1/
 # This is set after the dependency install so we can cache that layer
+ARG BUILD_DATE
+ARG BUILD_VERSION
+ARG VCS_REF
+
 LABEL org.label-schema.schema-version="1.0" \
       org.label-schema.build-date=$BUILD_DATE \
       org.label-schema.name="vaporio/synse-server" \