Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add metadata to scan output #335

Merged
merged 1 commit into from
Aug 29, 2019
Merged

add metadata to scan output #335

merged 1 commit into from
Aug 29, 2019

Conversation

edaniszewski
Copy link
Contributor

This PR:

  • adds a 'metadata' field to the scan output, populated with the metadata (context) from the gRPC response
  • updates deps
  • bumps to 3.0.0-alpha.8

This addition to the scan output serves multiple purposes:

  • exposes arbitrary device data to the user which can be used for additional filtering/aggregation
  • makes devices easier to identify from a flat scan result, visually

@edaniszewski edaniszewski mentioned this pull request Aug 29, 2019
Merged
KylerBurke
KylerBurke approved these changes Aug 29, 2019
View reviewed changes
Copy link
Contributor

@KylerBurke KylerBurke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping metadata as the key? More descriptive than context I suppose.

@hoanhan101 hoanhan101 mentioned this pull request Aug 29, 2019
Closed
@edaniszewski edaniszewski merged commit c5e1b46 into v3/staging Aug 29, 2019
@edaniszewski edaniszewski deleted the v3/scan-context branch August 29, 2019 16:19
edaniszewski added a commit that referenced this pull request Mar 27, 2020
@edaniszewski
add metadata to scan output (#335)
6bb1353
edaniszewski added a commit that referenced this pull request Mar 30, 2020
@edaniszewski
add metadata to scan output (#335)
4223e46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KylerBurke KylerBurke KylerBurke approved these changes

@hoanhan101 hoanhan101 hoanhan101 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@edaniszewski @KylerBurke @hoanhan101