/console

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic to parse single `-` prefixed flags #59

Merged
merged 1 commit into from Mar 12, 2018

Conversation

Reviewers

@tanner0101 tanner0101

Assignees

@tanner0101 tanner0101

Labels
bug
Projects
  
Vapor 3 (awaiting triage)
Milestone
  3.0.0-rc.2
2 participants
@siemensikkema @tanner0101
@siemensikkema
Copy link
Member

siemensikkema commented Mar 6, 2018

This prevents dangling - after detecting - prefixed flags which results in the following error: CommandError.excessInput: Too many arguments or unsupported options were supplied

@siemensikkema siemensikkema requested a review from tanner0101 Mar 6, 2018

@tanner0101 tanner0101 changed the base branch from master to nio Mar 12, 2018

@tanner0101 tanner0101 added this to the 3.0.0-rc.2 milestone Mar 12, 2018

@tanner0101 tanner0101 added the bug label Mar 12, 2018

@tanner0101 tanner0101 self-assigned this Mar 12, 2018

@tanner0101

This comment has been minimized.

Sign in to view
Copy link
Member

tanner0101 commented Mar 12, 2018

Awesome, thanks @siemensikkema!

@tanner0101 tanner0101 merged commit 0a82071 into nio Mar 12, 2018
1 check passed

1 check passed

ci/circleci: linux Your tests passed on CircleCI!
Details

@tanner0101 tanner0101 deleted the feature/fix-parsing-single-hyphen-options branch Mar 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment