New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a memory leak in QueueHandler #134

Merged
merged 1 commit into from Apr 21, 2018

Conversation

2 participants
@MrMage
Copy link
Contributor

MrMage commented Apr 21, 2018

QueueHandler sometimes retains the context it is executing on in waitingCtx. That context's handler is the QueueHandler itself, leading to a retain cycle. We break it by making waitingCtx a weak reference.

Fix a memory leak in QueueHandler
`QueueHandler` sometimes retains the context it is executing on in `waitingCtx`. That context's handler is the `QueueHandler` itself, leading to a retain cycle. We break it by making `waitingCtx` a weak reference.

@tanner0101 tanner0101 added the bug label Apr 21, 2018

@tanner0101 tanner0101 self-assigned this Apr 21, 2018

@tanner0101

This comment has been minimized.

Copy link
Member

tanner0101 commented Apr 21, 2018

Thanks!

@tanner0101 tanner0101 merged commit 89d4701 into master Apr 21, 2018

8 checks passed

ci/circleci: linux Your tests passed on CircleCI!
Details
ci/circleci: linux-fluent-mysql Your tests passed on CircleCI!
Details
ci/circleci: linux-fluent-postgresql Your tests passed on CircleCI!
Details
ci/circleci: linux-fluent-sqlite Your tests passed on CircleCI!
Details
ci/circleci: linux-jwt Your tests passed on CircleCI!
Details
ci/circleci: linux-leaf Your tests passed on CircleCI!
Details
ci/circleci: linux-redis Your tests passed on CircleCI!
Details
ci/circleci: linux-vapor Your tests passed on CircleCI!
Details

@tanner0101 tanner0101 added this to the 3.1.3 milestone Apr 21, 2018

@tanner0101 tanner0101 deleted the fix-leak-queuehandler branch Apr 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment