Skip to content
This repository has been archived by the owner on Nov 16, 2020. It is now read-only.

Release pooled conn when catch for requestPooledConnection #25

Merged
merged 3 commits into from
Apr 20, 2018
Merged

Release pooled conn when catch for requestPooledConnection #25

merged 3 commits into from
Apr 20, 2018

Conversation

vkill
Copy link
Contributor

@vkill vkill commented Apr 8, 2018

No description provided.

tanner0101
tanner0101 reviewed Apr 16, 2018
View reviewed changes
Copy link
Member

@tanner0101 tanner0101 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! Might be even better to do this using an .always?

let future: ...
future.always {
    // happens even if there is an error
}
return future

@tanner0101 tanner0101 added the enhancement New feature or request label Apr 16, 2018
@tanner0101 tanner0101 self-assigned this Apr 16, 2018
@vkill
Copy link
Contributor Author

vkill commented Apr 19, 2018

hi, it's done. please check again.

@tanner0101
Copy link
Member

thanks!

@tanner0101 tanner0101 merged commit 6252b11 into vapor:master Apr 20, 2018
@tanner0101 tanner0101 added this to the 1.0.0 milestone Apr 20, 2018
@tanner0101 tanner0101 mentioned this pull request Apr 20, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tanner0101 tanner0101 tanner0101 left review comments

Assignees

@tanner0101 tanner0101

Labels
enhancement New feature or request
Projects
No open projects
Vapor 3
  
Awaiting triage
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vkill @tanner0101