New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release pooled conn when catch for requestPooledConnection #25

Merged
merged 3 commits into from Apr 20, 2018

Conversation

2 participants
@vkill
Copy link
Contributor

vkill commented Apr 8, 2018

No description provided.

@tanner0101
Copy link
Member

tanner0101 left a comment

Awesome, thanks! Might be even better to do this using an .always?

let future: ...
future.always {
    // happens even if there is an error
}
return future

@tanner0101 tanner0101 self-assigned this Apr 16, 2018

@vkill

This comment has been minimized.

Copy link
Contributor Author

vkill commented Apr 19, 2018

hi, it's done. please check again.

@tanner0101

This comment has been minimized.

Copy link
Member

tanner0101 commented Apr 20, 2018

thanks!

@tanner0101 tanner0101 merged commit 6252b11 into vapor:master Apr 20, 2018

6 of 7 checks passed

ci/circleci: linux-vapor Your tests failed on CircleCI
Details
ci/circleci: linux Your tests passed on CircleCI!
Details
ci/circleci: linux-fluent Your tests passed on CircleCI!
Details
ci/circleci: linux-fluent-mysql Your tests passed on CircleCI!
Details
ci/circleci: linux-fluent-postgresql Your tests passed on CircleCI!
Details
ci/circleci: linux-fluent-sqlite Your tests passed on CircleCI!
Details
ci/circleci: linux-redis Your tests passed on CircleCI!
Details

@tanner0101 tanner0101 added this to the 1.0.0 milestone Apr 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment