This repository has been archived by the owner on Nov 16, 2020. It is now read-only.
DatabaseKit 2.0 #53
Merged
DatabaseKit 2.0 #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThreadConnectionPool + new algorithm
Mordil
reviewed
Jan 17, 2019
| /// Creates a new `DatabaseConnection` that will perform async work on the supplied `Worker`. | ||
| /// | ||
| /// let conn = try database.newConnection(on: ...).wait() | ||
| /// | ||
| /// - parameters: | ||
| /// - worker: `Worker` to perform async work on. | ||
| func newConnection(on worker: Worker) -> Future<Connection> | ||
| func newConnection() -> EventLoopFuture<Connection> |
There was a problem hiding this comment.
Shouldn't this be makeConnection() as per the Swift API Design Guidelines?
There was a problem hiding this comment.
@Mordil yeah, I think it should. I've added this to the TODO, thanks.
|
Hey @tanner0101, you just merged a pull request, have a coin! You now have 1012 coins. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates DatabaseKit to rely solely on SwiftNIO, making it more widely accessible to the server-side Swift ecosystem. It also updates
DatabaseConnectionPoolto share connections across event loops. This will make it easier to inject connection pools into various dependencies, without needing to ensure there is only one pool initialized per thread.new..->make..