Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand on why shutdown() needs to be used in unit tests #809

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Expand on why shutdown() needs to be used in unit tests #809

merged 2 commits into from
Jun 1, 2023

Conversation

MultiColourPixel
Copy link
Contributor

@MultiColourPixel MultiColourPixel commented May 31, 2023 •
edited
Loading

This PR is a follow-up to the conversation around this topic in Discord: https://discord.com/channels/431917998102675485/484454139506458634/1113123137240973404

0xTim
0xTim approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@0xTim 0xTim enabled auto-merge (squash) June 1, 2023 10:02
@0xTim 0xTim merged commit 0468bbd into vapor:main Jun 1, 2023
1 check passed
@github-actions github-actions bot mentioned this pull request Jun 1, 2023
Closed
5 tasks
@MultiColourPixel MultiColourPixel deleted the shutdown-documentation branch June 1, 2023 10:10
@redsun redsun mentioned this pull request Jun 12, 2023
Merged
@BennyDeBock BennyDeBock mentioned this pull request Jul 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xTim 0xTim 0xTim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MultiColourPixel @0xTim