Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update hljs and code blocks style #813

Merged
merged 2 commits into from
Jun 5, 2023
Merged

Update hljs and code blocks style #813

merged 2 commits into from
Jun 5, 2023

Conversation

ptoffy
Copy link
Member

@ptoffy ptoffy commented Jun 1, 2023

  • This updates the highlight.js version to be able to use better code highlighting
  • Also updates the code blocks style

@ptoffy ptoffy requested review from 0xTim and gwynne June 1, 2023 13:13
@ptoffy ptoffy added enhancement no-translation-needed This PR does not require the translations to be updated (e.g. fixing a typo or infrastructure work) labels Jun 1, 2023
0xTim
0xTim reviewed Jun 2, 2023
View reviewed changes
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can pull all these files in from design.vapor.codes instead?

@ptoffy
Copy link
Member Author

ptoffy commented Jun 2, 2023 •
edited
Loading

I wonder if we can pull all these files in from design.vapor.codes instead?

We could pull in the highlighting library (which we can use CDN for anyway) but the syntax.css file is slightly different

@0xTim 0xTim merged commit 68e16c5 into vapor:main Jun 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xTim 0xTim 0xTim approved these changes

@gwynne gwynne Awaiting requested review from gwynne gwynne is a code owner

Assignees
No one assigned
Labels
enhancement no-translation-needed This PR does not require the translations to be updated (e.g. fixing a typo or infrastructure work)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ptoffy @0xTim