Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example to populate pivot properties #815

Merged
merged 3 commits into from
Jun 5, 2023
Merged

Example to populate pivot properties #815

merged 3 commits into from
Jun 5, 2023

Conversation

alemohamad
Copy link
Member

@alemohamad alemohamad commented Jun 2, 2023 •
edited
Loading

Add explanation on how to use the callback closure in attach method to populate properties in pivot model.

gwynne
gwynne requested changes Jun 3, 2023
View reviewed changes
Copy link
Member

@gwynne gwynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I've recommended some tweaks for grammar and completeness.

docs/fluent/relations.md Outdated Show resolved Hide resolved
docs/fluent/relations.md Outdated Show resolved Hide resolved
docs/fluent/relations.md Show resolved Hide resolved
docs/fluent/relations.md Show resolved Hide resolved
@gwynne gwynne added the updates Adding new or updated documentation. label Jun 3, 2023
@alemohamad
Copy link
Member Author

Thanks @gwynne for your feedback! I believe that this adds more context to the readers. The changes are already applied. 👍

@alemohamad alemohamad requested a review from gwynne June 3, 2023 09:38
@gwynne gwynne requested a review from 0xTim June 3, 2023 09:49
0xTim
0xTim approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@0xTim 0xTim enabled auto-merge (squash) June 5, 2023 11:50
@0xTim 0xTim merged commit cd336c7 into vapor:main Jun 5, 2023
1 check passed
@github-actions github-actions bot mentioned this pull request Jun 5, 2023
Closed
5 tasks
@alemohamad alemohamad deleted the kb/siblings-properties branch June 6, 2023 17:26
@redsun redsun mentioned this pull request Jun 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwynne gwynne gwynne approved these changes

@0xTim 0xTim 0xTim approved these changes

Assignees
No one assigned
Labels
updates Adding new or updated documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alemohamad @gwynne @0xTim