Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Started Polish translation and translated index.md #845

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Started Polish translation and translated index.md #845

merged 1 commit into from
Jul 4, 2023

Conversation

VerticalHeretic
Copy link
Collaborator

It starts translation issue #844 with index.md translation and mkdocs.yml

@VerticalHeretic VerticalHeretic self-assigned this Jun 23, 2023
@VerticalHeretic VerticalHeretic added enhancement translation-update This PR contains translations for the docs and removed enhancement labels Jun 23, 2023
@alemohamad
Copy link
Member

@VerticalHeretic please add a Polish option in the .github/workflows/translation-issue-template.md file. 😉

@VerticalHeretic VerticalHeretic removed their assignment Jun 23, 2023
@VerticalHeretic
Copy link
Collaborator Author

@alemohamad Done 🫡

@VerticalHeretic VerticalHeretic force-pushed the translation/add-index-polish-translation branch from cde7b4e to a274842 Compare June 27, 2023 04:56
@mattesmohr
Copy link
Sponsor Member

mattesmohr commented Jun 28, 2023 •
edited

@VerticalHeretic Cause you have added comments like <!-- TODO: Add installation link to Polish version when created -->.

You don't need to change the link by the way. If there is a translation, MKDocs redirects automatically to it, based on the selected language.

@VerticalHeretic
Copy link
Collaborator Author

@mattesmohr oh then stupid me, I'm new to MKDocs. Will delete the comment then.

@VerticalHeretic VerticalHeretic force-pushed the translation/add-index-polish-translation branch from a274842 to cec86b8 Compare June 29, 2023 13:17
@VerticalHeretic
Added translation to Polish for:
616ca9f 
- index.md
- mkdocs.yml - nav etc.
@VerticalHeretic VerticalHeretic force-pushed the translation/add-index-polish-translation branch from cec86b8 to 616ca9f Compare June 29, 2023 13:17
mattesmohr
mattesmohr approved these changes Jul 4, 2023
View reviewed changes
Copy link
Sponsor Member

@mattesmohr mattesmohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattesmohr mattesmohr merged commit 82894c6 into main Jul 4, 2023
1 check passed
@mattesmohr mattesmohr deleted the translation/add-index-polish-translation branch July 4, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrroyal rrroyal rrroyal approved these changes

@mattesmohr mattesmohr mattesmohr approved these changes

Assignees
No one assigned
Labels
translation-update This PR contains translations for the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@VerticalHeretic @alemohamad @mattesmohr @rrroyal